Change Attributes Syntax from @@Attr to @{Attr}#6012
Closed
gharlan wants to merge 3 commits intophp:masterfrom
Closed
Change Attributes Syntax from @@Attr to @{Attr}#6012gharlan wants to merge 3 commits intophp:masterfrom
gharlan wants to merge 3 commits intophp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose
@{Attr}for the attributes syntax.Pro:
@@,@:and@[])@[Attr]and#[Attr])use App\{Foo, Bar, Baz as Qux}), where{}is already used for a comma separated listCon:
@{ ORM\Entity, ORM\Table("user") } class User { @{ORM\Id, ORM\Column("integer"), ORM\GeneratedValue} private $id; @{ORM\Column("string", ORM\Column::UNIQUE)} @{Assert\Email(["message" => "The email '{{ value }}' is not a valid email."])} private $email; }@beberlei Is it possible to include this in https://wiki.php.net/rfc/shorter_attribute_syntax_change? Since there will be a STV anyway, I think it doesn't hurt to have one more option to choose from.