Change Attribute Syntax from @@ to #[]#5989
Closed
beberlei wants to merge 1 commit intophp:masterfrom
Closed
Conversation
03802a7 to
80d4ab1
Compare
Member
|
Tests for grouping? |
80d4ab1 to
8008e3c
Compare
Contributor
Author
|
@nikic right, i have added some now in |
nikic
approved these changes
Sep 2, 2020
theodorejb
reviewed
Sep 2, 2020
| --FILE-- | ||
| <?php | ||
|
|
||
| #[A1(1), A1(2), A2(3)] |
Contributor
There was a problem hiding this comment.
It would be good to also test that grouping works for attributes without an argument list.
8008e3c to
4f1a879
Compare
Contributor
Author
|
Merged in 8b37c1e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same patch as for the @[Attr] syntax, replacing @[ with #[. No other changes are necessary.
RFC: https://wiki.php.net/rfc/shorter_attribute_syntax_change