PHANTOM
🇮🇳 IN
Skip to content

Fixes Commit hash should use a monospace font #2957#2968

Merged
alexr00 merged 2 commits intomicrosoft:mainfrom
burkeholland:burkeholland-issue2957
Oct 26, 2021
Merged

Fixes Commit hash should use a monospace font #2957#2968
alexr00 merged 2 commits intomicrosoft:mainfrom
burkeholland:burkeholland-issue2957

Conversation

@burkeholland
Copy link
Collaborator

@burkeholland burkeholland commented Aug 27, 2021

Fixes #2957

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some slightly off positioning/padding/sizing with this:
image

@alexr00 alexr00 added this to the September 2021 milestone Sep 1, 2021
@alexr00 alexr00 modified the milestones: September 2021, October 2021 Sep 27, 2021
@burkeholland
Copy link
Collaborator Author

SHEESH what a catch!

I think this is strictly due to the differences in the having these two fonts next to each other. The easy fix is to just add some negative margin to the .sha class as I don't see it being a problem anywhere else.

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexr00 alexr00 merged commit 09ee8be into microsoft:main Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commit hash should use a monospace font

2 participants