Add support for textDocument/inlineValues#806
Merged
dbaeumer merged 3 commits intomicrosoft:mainfrom Oct 25, 2021
DanTup:inline-values
Merged
Add support for textDocument/inlineValues#806dbaeumer merged 3 commits intomicrosoft:mainfrom DanTup:inline-values
dbaeumer merged 3 commits intomicrosoft:mainfrom
DanTup:inline-values
Conversation
Member
|
@DanTup I will merge it in, but usually a PR like this needs a markdown file describing the feature so that we can merge it into the protocol later on. And it should all start in proposed state. I will do the necessary changes. |
Member
|
I saw that you have a PR for this also in LSP land which is fine. Will simply copy the markdown for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first pass at implementing support for inlineValues proposed in the LSP repo at microsoft/language-server-protocol#1318 (to mirror VS Code's equivalent API https://code.visualstudio.com/api/references/vscode-api#InlineValuesProvider).
@dbaeumer I haven't built an implementation in a real server yet, but I did add integration/converter tests that are all passing (if I've missed any tests I should've added, please let me know!). I'd like to see this working end to end (eg. a real server having its values rendered inside VS Code) but it may take me a little longer to do that, so I figured it was worth opening a PR for feedback on the code (I don't expect end-to-end testing will result in any significant changes).
I've assumed this would go into 3.17 (as with the spec), but if 3.17 is close to release and that's not feasible, let me know and I'll update them both to 3.18.