enhance: add partial Persian translation#10938
Merged
logseq-cldwalker merged 11 commits intologseq:masterfrom Feb 5, 2024
Merged
enhance: add partial Persian translation#10938logseq-cldwalker merged 11 commits intologseq:masterfrom
logseq-cldwalker merged 11 commits intologseq:masterfrom
Conversation
|
|
adb475a to
da55e54
Compare
Contributor
Author
|
I am done with my changes for this PR. The key sections are translated now. I will include other translations later based on the feedback I receive from users. |
Contributor
Author
|
I don't think the failure of the e2e test is related to my changes. Am I right? |
logseq-cldwalker
approved these changes
Feb 5, 2024
Collaborator
logseq-cldwalker
left a comment
There was a problem hiding this comment.
@ahangarha Thanks for adding a new language and being the first RTL one! 👍 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial (nearly half) translation of Logseq into the Persian language. Please let me know if this can be merged or if I should make any other changes.
It seems Persian is the first RTL (right to left) language being added to Logseq. This means Logseq should consider adding support for RTL layout, too. It is not crucial for now, but it is better to have it in mind.