feat(modal): add drag events for sheet and card modals#30962
Open
thetaPC wants to merge 10 commits intofeature-8.8from
Open
feat(modal): add drag events for sheet and card modals#30962thetaPC wants to merge 10 commits intofeature-8.8from
thetaPC wants to merge 10 commits intofeature-8.8from
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
commented
Feb 20, 2026
Comment on lines
-696
to
-720
| /** | ||
| * While the gesture animation is finishing | ||
| * it is possible for a user to tap the backdrop. | ||
| * This would result in the dismiss animation | ||
| * being played again. Typically this is avoided | ||
| * by setting `presented = false` on the overlay | ||
| * component; however, we cannot do that here as | ||
| * that would prevent the element from being | ||
| * removed from the DOM. | ||
| */ | ||
| this.gestureAnimationDismissing = true; | ||
|
|
||
| /** | ||
| * Reset the status bar style as the dismiss animation | ||
| * starts otherwise the status bar will be the wrong | ||
| * color for the duration of the dismiss animation. | ||
| * The dismiss method does this as well, but | ||
| * in this case it's only called once the animation | ||
| * has finished. | ||
| */ | ||
| setCardStatusBarDefault(this.statusBarStyle); | ||
| this.animation!.onFinish(async () => { | ||
| await this.dismiss(undefined, GESTURE); | ||
| this.gestureAnimationDismissing = false; | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
This was moved to a new function called cardOnDismiss()
thetaPC
commented
Feb 26, 2026
Contributor
Author
There was a problem hiding this comment.
Screenshots updated because a new button and a new header was added behind the modal.
thetaPC
commented
Feb 26, 2026
Contributor
Author
There was a problem hiding this comment.
When adding new events to an overlay, we need to also add them to this file else devs won't be able to use them within a tag like @ionDragStart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
The sheet and card modal can be dragged to view content. However, there are no events that determine when drag has started or ended.
What is the new behavior?
ionDragStart,ionDragMove,ionDragEndDoes this introduce a breaking change?
Other information
Dev build:
8.7.17-dev.11772118942.181221d4