update Width to report in physical pixels#61
Merged
Conversation
Contributor
|
LGTM for these changes, but we'd need to also change the browser implementation considerations document. |
Owner
Author
|
Updated UA considerations doc. |
Contributor
|
LGTM |
igrigorik
added a commit
that referenced
this pull request
Sep 16, 2015
update Width to report in physical pixels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We originally defined
Widthto report in CSS px because the same header was responsible for reporting both the "intended image display width", or the "layout viewport size" for resources that don't have a "display width". However, we've since split these use cases (see #48) into separate headers:Viewport-WidthandWidth.This update changes the definition of
Widthto report image display width (when it's known) in physical pixels, instead of CSS pixels. This offers a couple of important benefits:w descriptorused for viewport-based selection.Vary: DPR, Width) which leads to unnecessary fragmentation (see viewport-based selection use case and caching #59).Closes #59.