Publish Fat Jar to Blob Storage Steps Decouple and Fix#990
Merged
Yuqing-cat merged 3 commits intofeathr-ai:mainfrom Jan 19, 2023
Merged
Publish Fat Jar to Blob Storage Steps Decouple and Fix#990Yuqing-cat merged 3 commits intofeathr-ai:mainfrom
Yuqing-cat merged 3 commits intofeathr-ai:mainfrom
Conversation
Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
blrchen
approved these changes
Jan 19, 2023
jainr
reviewed
Jan 19, 2023
Collaborator
jainr
left a comment
There was a problem hiding this comment.
How did you test the changes?
jainr
approved these changes
Jan 19, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previous publish to maven failure was fixed, however the follow up gradle build step failed.
This PR decouple the "publish-to-maven" & "publish-fat-jar" into 2 workflow to make sure files created by gradle publish will not affect fat jar.
How was this PR tested?
Tested in forked repo: https://github.com/Yuqing-cat/feathr/actions/runs/3949075762/jobs/6759841533
Does this PR introduce any user-facing changes?