Merged
Conversation
Signed-off-by: Boli Guan <ifendoe@gmail.com>
Member
|
Thanks for the PR! @Fendoe is there a staging env that folks can play with? |
Contributor
Author
|
@xiaoyongzhu Blair will provide it tomorrow. |
Signed-off-by: Boli Guan <ifendoe@gmail.com>
Signed-off-by: Boli Guan <ifendoe@gmail.com>
Collaborator
@xiaoyongzhu please checkout this staging link: https://brave-moss-045d2ce00-25.eastasia.1.azurestaticapps.net |
blrchen
reviewed
Jan 5, 2023
Collaborator
|
@Fendoe I did some test and find a bug for unhappy path. To repro this, just create a feature with a name that already exists in project, the api responses 400 correctly but UI displays feature created successfully message. The expected behavior is UI should display the 400 error message returned from api to tell user detail error. |
Signed-off-by: Boli Guan <ifendoe@gmail.com>
blrchen
approved these changes
Jan 5, 2023
Yuqing-cat
approved these changes
Jan 10, 2023
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Boli Guan ifendoe@gmail.com
Description
Resolves #488
How was this PR tested?
Does this PR introduce any user-facing changes?