Merged
Conversation
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
xiaoyongzhu
previously approved these changes
Dec 18, 2022
xiaoyongzhu
reviewed
Dec 18, 2022
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
blrchen
reviewed
Dec 21, 2022
blrchen
reviewed
Dec 21, 2022
blrchen
approved these changes
Dec 22, 2022
xiaoyongzhu
approved these changes
Dec 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some notebooks require to check if the notebook is running on synapse. This is a bit hacky way to check the platform but working solution.
More explicit way should be using a spark context, but then we have to pass the spark object to the function as an argument.
How was this PR tested?
Unit tests for negative cases.
Manual tests (on databricks and synapse) for positive cases.
Does this PR introduce any user-facing changes?