PHANTOM
🇮🇳 IN
Skip to content

Add postgis reflection query#19117

Draft
othercorey wants to merge 1 commit into5.nextfrom
reflect-geospatial
Draft

Add postgis reflection query#19117
othercorey wants to merge 1 commit into5.nextfrom
reflect-geospatial

Conversation

@othercorey
Copy link
Contributor

This is unused until we can decide how to handle the various versions of POINT.

Reverted the column regex now that we don't need to parse complex types.

@othercorey othercorey added this to the 5.3.0 milestone Dec 13, 2025
@othercorey othercorey requested a review from markstory December 13, 2025 05:53

$columns = $this->_driver->execute($sql, [$table, $schema, $catalog])->fetchAll('assoc');

return array_combine(array_column($columns, 'name'), $columns);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think mysql has the same table structure for their geospatial types.

@dereuromark
Copy link
Member

Small CS fail.

@othercorey othercorey marked this pull request as draft December 13, 2025 22:17
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@othercorey othercorey modified the milestones: 5.3.0, 5.3.1, 5.4.0 Jan 11, 2026
@dereuromark
Copy link
Member

dereuromark commented Jan 25, 2026

@markstory
You approved this.

Unused variable $postgisColumns

The core question is: how should the PostGIS metadata (geometry/geography type and SRID) be represented in CakePHP's schema reflection? Once that's decided, the $postgisColumns data needs to be merged into the column info being returned.
Currently it seems incomplete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants