[Button]: deprecate fab prop in favor of iconOnly#673
Open
Conversation
Contributor
|
👋 Thanks for Submitting! This PR is available for preview at the link below. ✅ PR tip preview: https://673.pr.nala.bravesoftware.com/ - ./tokens/css/variables-android.old.css: 7424 bytes
+ ./tokens/css/variables-android.css: 7424 bytes
---
- ./tokens/css/variables-browser.old.css: 19178 bytes
+ ./tokens/css/variables-browser.css: 19178 bytes
---
- ./tokens/css/variables-ios.old.css: 7067 bytes
+ ./tokens/css/variables-ios.css: 7067 bytes
---
- ./tokens/css/variables-marketing.old.css: 13561 bytes
+ ./tokens/css/variables-marketing.css: 13561 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1941 bytes
+ ./tokens/css/variables-newtab.css: 1941 bytes
---
- ./tokens/css/variables-search.old.css: 2419 bytes
+ ./tokens/css/variables-search.css: 2419 bytes
---
- ./tokens/css/variables-web3.old.css: 905 bytes
+ ./tokens/css/variables-web3.css: 905 bytes
---
- ./tokens/css/variables.old.css: 57399 bytes
+ ./tokens/css/variables.css: 57399 bytes
Variables Diff: variables-android.diff--- ./tokens/css/variables-android.old.css 2024-05-14 03:34:59.445321551 +0000
+++ ./tokens/css/variables-android.css 2024-05-14 03:34:17.468562552 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue May 14 2024 02:28:31 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue May 14 2024 03:34:17 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-browser.diff--- ./tokens/css/variables-browser.old.css 2024-05-14 03:34:59.941330687 +0000
+++ ./tokens/css/variables-browser.css 2024-05-14 03:34:17.432561721 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue May 14 2024 02:28:31 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue May 14 2024 03:34:17 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-ios.diff--- ./tokens/css/variables-ios.old.css 2024-05-14 03:35:00.449340040 +0000
+++ ./tokens/css/variables-ios.css 2024-05-14 03:34:17.488563014 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue May 14 2024 02:28:31 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue May 14 2024 03:34:17 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-marketing.diff--- ./tokens/css/variables-marketing.old.css 2024-05-14 03:35:00.789346302 +0000
+++ ./tokens/css/variables-marketing.css 2024-05-14 03:34:17.512563568 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue May 14 2024 02:28:31 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue May 14 2024 03:34:17 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-news.diff--- ./tokens/css/variables-news.old.css 2024-05-14 03:35:01.125352487 +0000
+++ ./tokens/css/variables-news.css 2024-05-14 03:34:17.548564399 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue May 14 2024 02:28:31 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue May 14 2024 03:34:17 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-newtab.diff--- ./tokens/css/variables-newtab.old.css 2024-05-14 03:35:01.497359339 +0000
+++ ./tokens/css/variables-newtab.css 2024-05-14 03:34:17.556564584 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue May 14 2024 02:28:31 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue May 14 2024 03:34:17 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-search.diff--- ./tokens/css/variables-search.old.css 2024-05-14 03:35:01.913367000 +0000
+++ ./tokens/css/variables-search.css 2024-05-14 03:34:17.540564215 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue May 14 2024 02:28:31 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue May 14 2024 03:34:17 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-web3.diff--- ./tokens/css/variables-web3.old.css 2024-05-14 03:35:02.293373994 +0000
+++ ./tokens/css/variables-web3.css 2024-05-14 03:34:17.560564676 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue May 14 2024 02:28:31 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue May 14 2024 03:34:17 GMT+0000 (Coordinated Universal Time)
*/
@media (prefers-color-scheme: light) {
Variables Diff: variables.diff--- ./tokens/css/variables.old.css 2024-05-14 03:35:02.713381733 +0000
+++ ./tokens/css/variables.css 2024-05-14 03:34:17.316559043 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue May 14 2024 02:28:31 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue May 14 2024 03:34:17 GMT+0000 (Coordinated Universal Time)
*/
:root {
|
fallaciousreasoning
approved these changes
May 14, 2024
Collaborator
fallaciousreasoning
left a comment
There was a problem hiding this comment.
Approving - this is a definite improvement, but do you mind holding off merging it for a couple of days - want to try and get the NTP Search stuff landed, and it might require Nala bumps (and this will make bumping Nala complicated 😆 )
Collaborator
Author
Not at all. |
Collaborator
|
Just wondering out loud - could we change the prop to be <Button icon kind="outline">...</Button>more wondering, but could it Just Work (tm) if you only slot in an Icon? Or is that too magic |
Collaborator
Author
|
So we decided to split this out into an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.