[Analyse]: Begin work on script for analysing token usages by fallaciousreasoning · Pull Request #1048 · brave/leo

fallaciousreasoning · 2025-04-04T02:30:10Z

Example (from generated CSV):
https://docs.google.com/spreadsheets/d/1AYTaJGNGajpeQsTxULtzJapD-CRvnv7JI7oMScguHzA/edit?gid=1839258156#gid=1839258156

src/scripts/analyse-nala.ts

github-actions · 2025-04-06T21:55:15Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://1048.pr.nala.bravesoftware.com/
✅ Commit preview: https://1048.pr.nala.bravesoftware.com/commit-10300fa16c47c5ac1619f00bca1177966e432b72/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 119686 bytes
+ ./tokens/css/variables.css: 119686 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2025-04-06 21:53:50.179608388 +0000
+++ ./tokens/css/variables-android.css	2025-04-06 21:53:18.222127416 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Apr 02 2025 20:25:08 GMT+0000 (Coordinated Universal Time)
+ * Generated on Sun Apr 06 2025 21:53:18 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2025-04-06 21:53:50.366605275 +0000
+++ ./tokens/css/variables-browser.css	2025-04-06 21:53:18.209127638 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Apr 02 2025 20:25:08 GMT+0000 (Coordinated Universal Time)
+ * Generated on Sun Apr 06 2025 21:53:18 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2025-04-06 21:53:50.558602081 +0000
+++ ./tokens/css/variables-ios.css	2025-04-06 21:53:18.236127177 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Apr 02 2025 20:25:08 GMT+0000 (Coordinated Universal Time)
+ * Generated on Sun Apr 06 2025 21:53:18 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2025-04-06 21:53:50.741599041 +0000
+++ ./tokens/css/variables-marketing.css	2025-04-06 21:53:18.252126903 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Apr 02 2025 20:25:08 GMT+0000 (Coordinated Universal Time)
+ * Generated on Sun Apr 06 2025 21:53:18 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2025-04-06 21:53:50.977595137 +0000
+++ ./tokens/css/variables-news.css	2025-04-06 21:53:18.274126528 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Apr 02 2025 20:25:08 GMT+0000 (Coordinated Universal Time)
+ * Generated on Sun Apr 06 2025 21:53:18 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2025-04-06 21:53:51.127592656 +0000
+++ ./tokens/css/variables-newtab.css	2025-04-06 21:53:18.281126408 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Apr 02 2025 20:25:08 GMT+0000 (Coordinated Universal Time)
+ * Generated on Sun Apr 06 2025 21:53:18 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2025-04-06 21:53:51.310589629 +0000
+++ ./tokens/css/variables-search.css	2025-04-06 21:53:18.270126596 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Apr 02 2025 20:25:08 GMT+0000 (Coordinated Universal Time)
+ * Generated on Sun Apr 06 2025 21:53:18 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2025-04-06 21:53:51.423587758 +0000
+++ ./tokens/css/variables-web3.css	2025-04-06 21:53:18.285126340 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Apr 02 2025 20:25:08 GMT+0000 (Coordinated Universal Time)
+ * Generated on Sun Apr 06 2025 21:53:18 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2025-04-06 21:53:51.633584286 +0000
+++ ./tokens/css/variables.css	2025-04-06 21:53:18.067130062 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Apr 02 2025 20:25:07 GMT+0000 (Coordinated Universal Time)
+ * Generated on Sun Apr 06 2025 21:53:18 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

src/scripts/analyse-nala.ts

github-actions · 2025-04-07T00:20:56Z

src/scripts/analyse-nala.ts

+
+const getLineDateLookup = (filepath: string): number[] | undefined => {
+  try {
+    const content = execSync(`git blame --line-porcelain -- ${filepath}`, {


_{reported by reviewdog 🐶}
[semgrep] Detected calls to child_process from a function argument filepath. This could lead to a command injection if the input is user controllable. Try to avoid calls to child_process, and if it is needed ensure user input is correctly sanitized or sandboxed.

Source: https://semgrep.dev/r/javascript.lang.security.detect-child-process.detect-child-process

Cc @thypon @kdenhartog

can you include the changes from @kdenhartog ?

kdenhartog

This seems fine to me now with the updates

github-actions · 2025-04-08T23:46:07Z

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://1048.pr.nala.bravesoftware.com/
✅ Commit preview: https://1048.pr.nala.bravesoftware.com/commit-9c44212fec57e7fffaf6355477c3093f84da2485/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 120612 bytes
+ ./tokens/css/variables.css: 120612 bytes

Variables Diff: variables-android.diff

--- ./tokens/css/variables-android.old.css	2025-04-08 23:44:40.587563576 +0000
+++ ./tokens/css/variables-android.css	2025-04-08 23:44:07.915653373 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Apr 08 2025 19:20:32 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Apr 08 2025 23:44:07 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-browser.diff

--- ./tokens/css/variables-browser.old.css	2025-04-08 23:44:40.868562783 +0000
+++ ./tokens/css/variables-browser.css	2025-04-08 23:44:07.903653407 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Apr 08 2025 19:20:32 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Apr 08 2025 23:44:07 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-ios.diff

--- ./tokens/css/variables-ios.old.css	2025-04-08 23:44:41.167561972 +0000
+++ ./tokens/css/variables-ios.css	2025-04-08 23:44:07.930653331 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Apr 08 2025 19:20:32 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Apr 08 2025 23:44:07 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-marketing.diff

--- ./tokens/css/variables-marketing.old.css	2025-04-08 23:44:41.456561193 +0000
+++ ./tokens/css/variables-marketing.css	2025-04-08 23:44:07.950653275 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Apr 08 2025 19:20:32 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Apr 08 2025 23:44:07 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-news.diff

--- ./tokens/css/variables-news.old.css	2025-04-08 23:44:41.597560811 +0000
+++ ./tokens/css/variables-news.css	2025-04-08 23:44:07.972653213 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Apr 08 2025 19:20:32 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Apr 08 2025 23:44:07 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-newtab.diff

--- ./tokens/css/variables-newtab.old.css	2025-04-08 23:44:41.875560058 +0000
+++ ./tokens/css/variables-newtab.css	2025-04-08 23:44:07.979653193 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Apr 08 2025 19:20:32 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Apr 08 2025 23:44:07 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-search.diff

--- ./tokens/css/variables-search.old.css	2025-04-08 23:44:42.156559296 +0000
+++ ./tokens/css/variables-search.css	2025-04-08 23:44:07.967653227 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Apr 08 2025 19:20:32 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Apr 08 2025 23:44:07 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

Variables Diff: variables-web3.diff

--- ./tokens/css/variables-web3.old.css	2025-04-08 23:44:42.425558567 +0000
+++ ./tokens/css/variables-web3.css	2025-04-08 23:44:07.983653182 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Apr 08 2025 19:20:32 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Apr 08 2025 23:44:07 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {

Variables Diff: variables.diff

--- ./tokens/css/variables.old.css	2025-04-08 23:44:42.869557365 +0000
+++ ./tokens/css/variables.css	2025-04-08 23:44:07.766653794 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Tue Apr 08 2025 19:20:32 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Apr 08 2025 23:44:07 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

aguscruiz · 2025-04-10T20:18:39Z

Couple thoughts:

We probably don't want to categorize empty values as "non Nala".
Neither "inherit", maybe we can skip those instances.

Both of these I found on the Rewards tab on the spreadsheet.

thypon · 2025-06-11T16:49:59Z

src/scripts/analyse-nala.ts

+
+const getLineDateLookup = (filepath: string): number[] | undefined => {
+  try {
+    const content = execSync(`git blame --line-porcelain -- ${filepath}`, {


can you include the changes from @kdenhartog ?

fallaciousreasoning requested review from AlanBreck and petemill as code owners April 4, 2025 02:30

github-actions bot added the needs-security-review label Apr 4, 2025

github-actions bot assigned kdenhartog and thypon Apr 4, 2025

github-actions bot reviewed Apr 6, 2025

View reviewed changes

src/scripts/analyse-nala.ts Show resolved Hide resolved

kdenhartog reviewed Apr 6, 2025

View reviewed changes

src/scripts/analyse-nala.ts Show resolved Hide resolved

github-actions bot reviewed Apr 7, 2025

View reviewed changes

kdenhartog unassigned thypon and kdenhartog Apr 7, 2025

kdenhartog approved these changes Apr 7, 2025

View reviewed changes

fallaciousreasoning added 3 commits April 9, 2025 11:43

[Analyse]: Begin work on script for analysing token usages

8cbd1f7

[Analyse]: Add CSV output

097557e

Formatting

9c44212

fallaciousreasoning force-pushed the analyse-tokens branch from a943ee6 to 9c44212 Compare April 8, 2025 23:43

thypon requested changes Jun 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Analyse]: Begin work on script for analysing token usages#1048

[Analyse]: Begin work on script for analysing token usages#1048
fallaciousreasoning wants to merge 3 commits intomainfrom
analyse-tokens

fallaciousreasoning commented Apr 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

Uh oh!

github-actions bot Apr 7, 2025

Uh oh!

thypon Jun 11, 2025

Uh oh!

kdenhartog left a comment

Uh oh!

github-actions bot commented Apr 8, 2025

Uh oh!

aguscruiz commented Apr 10, 2025

Uh oh!

thypon Jun 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

fallaciousreasoning commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

Uh oh!

github-actions bot Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

thypon Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

kdenhartog left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 8, 2025

Uh oh!

aguscruiz commented Apr 10, 2025

Uh oh!

thypon Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fallaciousreasoning commented Apr 4, 2025 •

edited

Loading