[Dialog]: Set overflow hidden - dialogs shouldn't scroll#1006
Open
fallaciousreasoning wants to merge 1 commit intomainfrom
Open
[Dialog]: Set overflow hidden - dialogs shouldn't scroll#1006fallaciousreasoning wants to merge 1 commit intomainfrom
fallaciousreasoning wants to merge 1 commit intomainfrom
Conversation
Contributor
|
👋 Thanks for Submitting! This PR is available for preview at the link below. ✅ PR tip preview: https://1006.pr.nala.bravesoftware.com/ - ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 119686 bytes
+ ./tokens/css/variables.css: 119686 bytes
Variables Diff: variables-android.diff--- ./tokens/css/variables-android.old.css 2025-02-26 22:03:46.357132345 +0000
+++ ./tokens/css/variables-android.css 2025-02-26 22:03:05.386940183 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 26 2025 11:51:39 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 22:03:05 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-browser.diff--- ./tokens/css/variables-browser.old.css 2025-02-26 22:03:46.601133318 +0000
+++ ./tokens/css/variables-browser.css 2025-02-26 22:03:05.366940071 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 26 2025 11:51:39 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 22:03:05 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-ios.diff--- ./tokens/css/variables-ios.old.css 2025-02-26 22:03:46.826134213 +0000
+++ ./tokens/css/variables-ios.css 2025-02-26 22:03:05.407940300 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 26 2025 11:51:39 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 22:03:05 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-marketing.diff--- ./tokens/css/variables-marketing.old.css 2025-02-26 22:03:47.075135202 +0000
+++ ./tokens/css/variables-marketing.css 2025-02-26 22:03:05.431940434 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 26 2025 11:51:39 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 22:03:05 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-news.diff--- ./tokens/css/variables-news.old.css 2025-02-26 22:03:47.296136082 +0000
+++ ./tokens/css/variables-news.css 2025-02-26 22:03:05.462940608 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 26 2025 11:51:39 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 22:03:05 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-newtab.diff--- ./tokens/css/variables-newtab.old.css 2025-02-26 22:03:47.533137025 +0000
+++ ./tokens/css/variables-newtab.css 2025-02-26 22:03:05.472940663 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 26 2025 11:51:39 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 22:03:05 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-search.diff--- ./tokens/css/variables-search.old.css 2025-02-26 22:03:47.752137896 +0000
+++ ./tokens/css/variables-search.css 2025-02-26 22:03:05.454940563 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 26 2025 11:51:39 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 22:03:05 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-web3.diff--- ./tokens/css/variables-web3.old.css 2025-02-26 22:03:47.973138775 +0000
+++ ./tokens/css/variables-web3.css 2025-02-26 22:03:05.481940714 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 26 2025 11:51:39 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 22:03:05 GMT+0000 (Coordinated Universal Time)
*/
@media (prefers-color-scheme: light) {
Variables Diff: variables.diff--- ./tokens/css/variables.old.css 2025-02-26 22:03:48.331140200 +0000
+++ ./tokens/css/variables.css 2025-02-26 22:03:05.215939227 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Feb 26 2025 11:51:39 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 22:03:05 GMT+0000 (Coordinated Universal Time)
*/
:root {
|
AlanBreck
reviewed
Mar 25, 2025
Collaborator
AlanBreck
left a comment
There was a problem hiding this comment.
I'm not sure we want this. For instance, in landscape mode on mobile, we want the dialog to scroll.
Collaborator
Author
|
I think the whole Dialog should scroll, but the content of the dialog shouldn't scroll |
Collaborator
I agree, but this makes it so the dialog won't scroll, yes? Try viewing one of the stories in landscape mobile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.