fix(swap): remove redundant ×100 on Jupiter price impact already in percent#218
Open
fix(swap): remove redundant ×100 on Jupiter price impact already in percent#218
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Jupiter swap provider integration where price impact values were incorrectly multiplied by 100. According to the Jupiter Ultra V3 API documentation, the priceImpact field is already returned as a percentage value (e.g., -99.20 means -99.20%), so the multiplication was causing incorrect values to be reported.
Changes:
- Removed redundant multiplication by 100 for Jupiter price impact values
- Updated validation threshold from 1.0 to 100.0 to match percentage-based values
- Removed unused Decimal import
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/api/swap/providers/jupiter/transformations.py | Removed Decimal import, updated price impact validation threshold to 100.0, removed multiplication by 100, and added clarifying comment about Jupiter API behavior |
| app/api/swap/providers/jupiter/test_transformations.py | Updated test cases to reflect that price impact is already in percentage format, with invalid values now testing beyond ±100.0 and valid values testing passthrough behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Douglashdaniel
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://dev.jup.ag/api-reference/ultra/order#response-price-impact-pct