fix(swap): convert expires_at to Unix timestamp string#162
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR converts the expires_at field in the SwapRoute model from a datetime object to a Unix timestamp string, making it easier to parse and more versatile across swap providers.
Key Changes:
- Modified the
SwapRoutemodel to changeexpires_atfromdatetime | Nonetostr | None - Added conversion logic to transform the NEAR Intents deadline datetime into a Unix timestamp string
- Updated tests to verify the timestamp format and validate the conversion
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/api/swap/models.py | Changed expires_at field type from datetime | None to str | None and removed unused datetime import |
| app/api/swap/providers/near_intents/transformations.py | Added logic to convert the deadline datetime to a Unix timestamp string before setting expires_at |
| app/api/swap/providers/near_intents/test_client.py | Added comprehensive assertions to verify expires_at is a valid Unix timestamp string and matches the expected value |
The implementation is clean and well-tested. The conversion properly handles None values (indicative quotes), and the test coverage includes both cases where the deadline is present (firm quotes) and absent (indicative quotes). The use of int() to truncate to seconds is appropriate for Unix timestamps.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Douglashdaniel
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unix timestamp format is easier to parser and more versatile across swap providers.