● PHANTOM
🇮🇳 IN
✕
Skip to content

[Shields UI] Add advanced view to new panel UI#34192

Open
zenparsing wants to merge 1 commit intomasterfrom
ksmith-shields-panel-new-4
Open

[Shields UI] Add advanced view to new panel UI#34192
zenparsing wants to merge 1 commit intomasterfrom
ksmith-shields-panel-new-4

Conversation

@zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Feb 25, 2026

@zenparsing zenparsing requested a review from a team as a code owner February 25, 2026 19:53
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 25, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

📋 Code Owners Summary

5 file(s) changed, 1 with assigned owners

1 team(s) affected: @brave/string-reviewers-team

Owners and Their Files

@brave/string-reviewers-team — 1 file(s)

@brave-builds
Copy link
Collaborator

brave-builds commented Feb 25, 2026

Warning

You have got a presubmit warning. Please address it if possible.

Found 3 lines longer than 80 characters (first 5 shown).

Items:

components/brave_shields/resources/panel_new/components/advanced_settings.style.ts, line 66, 90 chars
components/brave_shields/resources/panel_new/components/advanced_settings.tsx, line 19, 83 chars
components/brave_shields/resources/panel_new/components/advanced_settings.tsx, line 21, 101 chars

@brave-builds
Copy link
Collaborator

brave-builds commented Feb 25, 2026

A Storybook has been deployed to preview UI for the latest push

mkarolin
mkarolin approved these changes Feb 26, 2026
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkarolin mkarolin mkarolin approved these changes

@fallaciousreasoning fallaciousreasoning Awaiting requested review from fallaciousreasoning

+1 more reviewer

@netzenbot netzenbot netzenbot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zenparsing zenparsing

Labels

CI/storybook-url Deploy storybook and provide a unique URL for each build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zenparsing @brave-builds @mkarolin @netzenbot