[News] Use interned strings for fast comparisons in feed building#34191
Open
zenparsing wants to merge 1 commit intomasterfrom
Open
[News] Use interned strings for fast comparisons in feed building#34191zenparsing wants to merge 1 commit intomasterfrom
zenparsing wants to merge 1 commit intomasterfrom
Conversation
83b9696 to
ac32adb
Compare
netzenbot
reviewed
Feb 25, 2026
| const std::vector<mojom::Signal*>& signals, | ||
| NameId publisher_id, | ||
| absl::flat_hash_set<NameId> channels, | ||
| const bool& discoverable) { |
Collaborator
There was a problem hiding this comment.
nit: const bool& is less efficient than passing bool by value — prefer bool directly. best practice
|
|
||
| std::string NameTable::GetString(NameId id) const { | ||
| if (!id) { | ||
| return ""; |
Collaborator
There was a problem hiding this comment.
nit: prefer std::optional<std::string> over empty string as a sentinel value — it makes the "no value" case explicit. best practice
Introduces a NameTable for interning publisher IDs and channel names, replacing string comparisons with integer comparisons during feed generation. Publisher-to-channel mappings are computed once and reused.
ac32adb to
1dcafb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a NameTable for interning publisher IDs and channel names, replacing string comparisons with integer comparisons during feed generation. Publisher-to-channel mappings are computed once and reused.
Subtask of brave/brave-browser#48969