PHANTOM
🇮🇳 IN
Skip to content

[Nala]: Add Android color tokens#34106

Merged
fallaciousreasoning merged 2 commits intomasterfrom
android-colors
Feb 24, 2026
Merged

[Nala]: Add Android color tokens#34106
fallaciousreasoning merged 2 commits intomasterfrom
android-colors

Conversation

@fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Feb 23, 2026

Series brave/brave-browser#52817

This PR needs brave/leo#1316 to land first but I'd like to get android devs eyes on asap.
Waiting on #34125 to get the changes into brave-core

TODO in follow ups:

  • replace colors in brave_colors.xml (where applicable)
  • wire references up in Nala colors
  • Get Nala colors responding to the Material Theme like they do on desktop

Second commit here can be reverted but just wanted to check I could use the Nala colors

@fallaciousreasoning fallaciousreasoning requested review from a team as code owners February 23, 2026 04:24
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Feb 23, 2026
Copy link
Collaborator

@netzenbot netzenbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review via brave-core-bot

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Collaborator

@netzenbot netzenbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review via brave-core-bot

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to rebase to remove the dep upgrade

@fallaciousreasoning fallaciousreasoning enabled auto-merge (squash) February 24, 2026 19:22
@fallaciousreasoning fallaciousreasoning removed the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Feb 24, 2026
@fallaciousreasoning fallaciousreasoning merged commit 2a3434f into master Feb 24, 2026
23 checks passed
@fallaciousreasoning fallaciousreasoning deleted the android-colors branch February 24, 2026 22:40
@github-actions github-actions bot added this to the 1.89.x - Nightly milestone Feb 24, 2026
@brave-builds
Copy link
Collaborator

Released in v1.89.72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants