PHANTOM
🇮🇳 IN
Skip to content

[Wallet]: Fix Shield and Unshield Unnecessary Warnings#33033

Merged
Douglashdaniel merged 1 commit intomasterfrom
wallet-fix-shield-and-unshield-unnecessary-warnings
Jan 6, 2026
Merged

[Wallet]: Fix Shield and Unshield Unnecessary Warnings#33033
Douglashdaniel merged 1 commit intomasterfrom
wallet-fix-shield-and-unshield-unnecessary-warnings

Conversation

@Douglashdaniel
Copy link
Contributor

Description

Fixes a bug where Shielding and Unshielding warnings would persist if the Send screen was reset and Zcash was reselected.

Resolves brave/brave-browser#51762

Test Plan:

  1. Open the Wallet and navigate to the Send screen
  2. Select Zcash to send and then select your Shielded account to send to
  3. You should see the Shielding warning
  4. Now click the Send button in the side nav, everything should reset
  5. Re-select Zcash as the asset to send
  6. The Shielding warning should not re-appear

Before:

Screen.Recording.mov

After:

Screen.Recording.1.mov

@Douglashdaniel Douglashdaniel self-assigned this Jan 5, 2026
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner January 5, 2026 23:36
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Jan 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

📋 Code Owners Summary

2 file(s) changed, 2 with assigned owners

1 team(s) affected: @brave/crypto-wallets-front-end


Owners and Their Files

@brave/crypto-wallets-front-end — 2 file(s)

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the wallet-fix-shield-and-unshield-unnecessary-warnings branch from abfa750 to 6b481c5 Compare January 6, 2026 16:17
@Douglashdaniel Douglashdaniel force-pushed the wallet-fix-shield-and-unshield-unnecessary-warnings branch from 6b481c5 to 1337b2f Compare January 6, 2026 20:58
@Douglashdaniel Douglashdaniel merged commit fe2491f into master Jan 6, 2026
20 checks passed
@Douglashdaniel Douglashdaniel deleted the wallet-fix-shield-and-unshield-unnecessary-warnings branch January 6, 2026 22:44
@github-actions github-actions bot added this to the 1.87.x - Nightly milestone Jan 6, 2026
@brave-builds
Copy link
Collaborator

Released in v1.87.153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Wallet] Shielded warning message is shown as soon as Send token is selected

3 participants