[Wallet]: Edit Visible Assets Model Performance Improvements#32894
Conversation
📋 Code Owners Summary4 file(s) changed, 4 with assigned owners 1 team(s) affected: Owners and Their Files
|
onyb
left a comment
There was a problem hiding this comment.
Left a small remark, otherwise looks good to me!
components/brave_wallet_ui/components/shared/create-placeholder-icon/index.tsx
Show resolved
Hide resolved
|
Chromium major version is behind target branch (143.0.7499.146 vs 144.0.7559.31). Please rebase. |
kdenhartog
left a comment
There was a problem hiding this comment.
I looked through this and made sure the NFTIconWrapper is still using chrome://image to sanitize the image and make sure we're not accidentally allowing an SVG image to load such that untrusted JS loaded from the image would be executed inside the WebUI and have access to mojo APIs.
This was my major concern previously which is why we previously iframed them. However, now that chrome://image is doing sanitization for us we don't need to be concerned about this and gain the performance improvements of dropping separate iframes.
b57b306 to
42295d1
Compare
42295d1 to
7cc1e09
Compare
Description
Improves the
Edit Visible Assetsmodel performancePreviously we would wrap each individual
NFTimage in achrome-untrusted://iframe for sanitization, this caused poor performance in theEdit Visible Assetsmodel if you owned a lot ofNFT'sThis change will now rely on
chrome://imageto handleNFTimage sanitization making theEdit Visible Assetsmodel a lot faster.Resolves brave/brave-browser#51519
Walletand then open theEdit Visible AssetsmodalBefore:
Screen.Recording.6.mov
After:
Screen.Recording.12.mov