PHANTOM
🇮🇳 IN
Skip to content

[iOS] Ensure share item is part of toolbar action button list#32205

Merged
kylehickinson merged 1 commit intomasterfrom
ios-share-button-transition
Nov 5, 2025
Merged

[iOS] Ensure share item is part of toolbar action button list#32205
kylehickinson merged 1 commit intomasterfrom
ios-share-button-transition

Conversation

@kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Nov 5, 2025

This updates the behaviour for swapping the forward & share buttons such that they are all added to the toolbar's actionButtons list and simply swap isHidden to control visibility. This fixes the issue where the share button wouldn't alpha out during interactive toolbar visibility transitions

Resolves brave/brave-browser#50645

Test Case

  • Load some webpage that can scroll
  • With share button visible, verify that when scrolling down & up a page slowly the share button disappears and reappears with the rest of the items
  • Tap a link on a page then tap back to make the forward button appear
  • Verify that when scrolling down & up a page slowly the forward button disappears and reappears with the rest of the items

This updates the behaviour for swapping the forward & share buttons such that they are all added to the toolbar's `actionButtons` list and simply swap `isHidden` to control visibility. This fixes the issue where the share button wouldn't alpha out during interactive toolbar visibility transitions
@kylehickinson kylehickinson self-assigned this Nov 5, 2025
@kylehickinson kylehickinson requested a review from a team as a code owner November 5, 2025 16:14
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity CI/skip-origin Do not run CI builds for Origin labels Nov 5, 2025
@kylehickinson kylehickinson merged commit 41fcf73 into master Nov 5, 2025
20 checks passed
@kylehickinson kylehickinson deleted the ios-share-button-transition branch November 5, 2025 23:43
@github-actions github-actions bot added this to the 1.86.x - Nightly milestone Nov 5, 2025
@brave-builds
Copy link
Collaborator

Released in v1.86.48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-origin Do not run CI builds for Origin CI/skip-windows-x64 Do not run CI builds for Windows x64

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share icon doesn't change opacity during transition to hide

3 participants