[types]: Omit children from svelte types in react bindings#3
Merged
benjaminknox merged 1 commit intobpk/svelte5from May 13, 2025
Merged
Conversation
f38fdd9 to
23c7cc0
Compare
Owner
Author
|
Going to merge into the Svelte5 branch that has a PR open. |
benjaminknox
added a commit
that referenced
this pull request
Sep 1, 2025
benjaminknox
added a commit
that referenced
this pull request
Nov 19, 2025
benjaminknox
added a commit
that referenced
this pull request
Nov 19, 2025
benjaminknox
added a commit
that referenced
this pull request
Nov 19, 2025
benjaminknox
added a commit
that referenced
this pull request
Nov 22, 2025
benjaminknox
added a commit
that referenced
this pull request
Nov 22, 2025
benjaminknox
added a commit
that referenced
this pull request
Dec 13, 2025
benjaminknox
added a commit
that referenced
this pull request
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In the svelte 5 react bindings, the children prop type on components resolve to
Snippet<[]>and we get type errors on something like this:The errors looked something like this:
Solution: Omit the children prop on the imported svelte types in a few areas, this seems to let it use the correct react children prop for types.
Details
childreninscripts/gen-react-bindings.jsin the imported svelte component typesleo-menu-itemandleo-option:HTMLAttributestype fromsvelte/elementsomit thechildrenpropchildrenwith the typestring | Elements[]HTMLAttributesto thecomponents/svelte-react.tsfile