● PHANTOM
🇮🇳 IN
✕
Skip to content

[Wasm-GC] Enable GC by default#31854

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
ddegazio:eng/Enable-WASM-GC-by-default
Aug 8, 2024
Merged

[Wasm-GC] Enable GC by default#31854
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
ddegazio:eng/Enable-WASM-GC-by-default

Conversation

@ddegazio
Copy link
Contributor

@ddegazio ddegazio commented Aug 7, 2024 •
edited by webkit-early-warning-system
Loading

70830b9

[Wasm-GC] Enable GC by default
https://bugs.webkit.org/show_bug.cgi?id=272004
rdar://126103011

Reviewed by Yusuke Suzuki.

Enables WASM GC by default in JavaScriptCore. This patch just
changes the default value of the useWasmGC() option, and skips
a few spec test assertions that are outdated under WASM GC
semantics.

* JSTests/wasm/extended-const-spec-tests/data.wast.js:
* JSTests/wasm/extended-const-spec-tests/elem.wast.js:
* JSTests/wasm/extended-const-spec-tests/global.wast.js:
* JSTests/wasm/spec-tests/data.wast.js:
* JSTests/wasm/spec-tests/elem.wast.js:
* JSTests/wasm/spec-tests/global.wast.js:
* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/281975@main

7da854b

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@ddegazio ddegazio requested a review from a team as a code owner August 7, 2024 21:09
@ddegazio ddegazio self-assigned this Aug 7, 2024
@ddegazio ddegazio added the WebAssembly For bugs in JavaScript WebAssembly label Aug 7, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 7, 2024 •
edited
Loading

EWS run on current version of this PR (hash 7da854b)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

Constellation
Constellation approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 8, 2024
@ddegazio @Constellation
[Wasm-GC] Enable GC by default
70830b9 
https://bugs.webkit.org/show_bug.cgi?id=272004
rdar://126103011

Reviewed by Yusuke Suzuki.

Enables WASM GC by default in JavaScriptCore. This patch just
changes the default value of the useWasmGC() option, and skips
a few spec test assertions that are outdated under WASM GC
semantics.

* JSTests/wasm/extended-const-spec-tests/data.wast.js:
* JSTests/wasm/extended-const-spec-tests/elem.wast.js:
* JSTests/wasm/extended-const-spec-tests/global.wast.js:
* JSTests/wasm/spec-tests/data.wast.js:
* JSTests/wasm/spec-tests/elem.wast.js:
* JSTests/wasm/spec-tests/global.wast.js:
* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/281975@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Enable-WASM-GC-by-default branch from 7da854b to 70830b9 Compare August 8, 2024 02:55
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Aug 8, 2024

Committed 281975@main (70830b9): https://commits.webkit.org/281975@main

Reviewed commits have been landed. Closing PR #31854 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 70830b9 into WebKit:main Aug 8, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 8, 2024
@ADKaster ADKaster mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Constellation Constellation Constellation approved these changes

Assignees

@ddegazio ddegazio

Labels

WebAssembly For bugs in JavaScript WebAssembly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ddegazio @webkit-early-warning-system @webkit-commit-queue @Constellation