Core/Items: Implement Sell All Junk button at vendors#31675
Open
agatho wants to merge 1 commit intoTrinityCore:masterfrom
Open
Core/Items: Implement Sell All Junk button at vendors#31675agatho wants to merge 1 commit intoTrinityCore:masterfrom
agatho wants to merge 1 commit intoTrinityCore:masterfrom
Conversation
The Sell All Junk button in the merchant UI never appeared because the client's C_MerchantFrame.IsSellAllJunkEnabled() reads a sellAllJunkEnabled CVar whose value is populated from the MirrorVar overlay sent via SMSG_MIRROR_VARS during authentication. Without this MirrorVar the CVar defaults to 0 and the button is hidden. Changes: - Send sellAllJunkEnabled=1 in SMSG_MIRROR_VARS (AuthHandler) - Implement CMSG_SELL_ALL_JUNK_ITEMS handler with full item filtering: poor quality, sellable, not refundable, not looted, respects per-bag ExcludeJunkSell flags and BackpackSellJunkDisabled player setting, adds sold items to buyback - Add SellAllJunkItems packet class (ItemPackets)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the Sell All Junk button in the merchant UI by sending
sellAllJunkEnabled=1viaSMSG_MIRROR_VARSand implementing theCMSG_SELL_ALL_JUNK_ITEMShandler.