PHANTOM
🇮🇳 IN
Skip to content

Core/Items: Implement Sell All Junk button at vendors#31675

Open
agatho wants to merge 1 commit intoTrinityCore:masterfrom
agatho:feature/sell-all-junk-button
Open

Core/Items: Implement Sell All Junk button at vendors#31675
agatho wants to merge 1 commit intoTrinityCore:masterfrom
agatho:feature/sell-all-junk-button

Conversation

@agatho
Copy link
Contributor

@agatho agatho commented Feb 12, 2026

Enable the Sell All Junk button in the merchant UI by sending sellAllJunkEnabled=1 via SMSG_MIRROR_VARS and implementing the CMSG_SELL_ALL_JUNK_ITEMS handler.

The Sell All Junk button in the merchant UI never appeared because the
client's C_MerchantFrame.IsSellAllJunkEnabled() reads a sellAllJunkEnabled
CVar whose value is populated from the MirrorVar overlay sent via
SMSG_MIRROR_VARS during authentication. Without this MirrorVar the CVar
defaults to 0 and the button is hidden.

Changes:
- Send sellAllJunkEnabled=1 in SMSG_MIRROR_VARS (AuthHandler)
- Implement CMSG_SELL_ALL_JUNK_ITEMS handler with full item filtering:
  poor quality, sellable, not refundable, not looted, respects per-bag
  ExcludeJunkSell flags and BackpackSellJunkDisabled player setting,
  adds sold items to buyback
- Add SellAllJunkItems packet class (ItemPackets)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant