Popup: remove Delete button and add Report button#8824
Open
DNin01 wants to merge 3 commits intoScratchAddons:masterfrom
Open
Popup: remove Delete button and add Report button#8824DNin01 wants to merge 3 commits intoScratchAddons:masterfrom
DNin01 wants to merge 3 commits intoScratchAddons:masterfrom
Conversation
Does not remove the Dismiss button from alerts (or at least it should not)
Samq64
reviewed
Feb 24, 2026
| v-if="canDeleteComment" | ||
| >{{ deleteStep === 0 ? messages.deleteMsg : messages.deleteConfirmMsg }} | ||
| </a> | ||
| <a class="delete-btn" rel="noopener noreferrer" target="_blank" :href="reportURL">{{ messages.reportMsg }} </a> |
Member
There was a problem hiding this comment.
Could this class be renamed to match its new purpose?
Suggested change
| <a class="delete-btn" rel="noopener noreferrer" target="_blank" :href="reportURL">{{ messages.reportMsg }} </a> | |
| <a class="report-btn" rel="noopener noreferrer" target="_blank" :href="reportURL">{{ messages.reportMsg }} </a> |
| <span v-show="deleting">{{ messages.deletingMsg }}</span> | ||
| <span v-show="deleted && !deleting">{{ messages.deletedMsg }}</span> | ||
| <dom-element-renderer :element="thisComment.content" v-show="!deleted"></dom-element-renderer> | ||
| <dom-element-renderer :element="thisComment.content"></dom-element-renderer> |
Member
There was a problem hiding this comment.
I haven't looked into it yet but is re-rendering still necessary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #477
Changes
Reason for changes
Tests
Tested with profile and project comments (no comments were reported).