Enable full vulkan support of specialization constants#770
Open
hzqst wants to merge 3 commits intoDiligentGraphics:specialization_constantsfrom
Open
Enable full vulkan support of specialization constants#770hzqst wants to merge 3 commits intoDiligentGraphics:specialization_constantsfrom
hzqst wants to merge 3 commits intoDiligentGraphics:specialization_constantsfrom
Conversation
…e Vulkan structs during PSO creation.
Contributor
Author
|
@TheMostDiligent why we have unrelated error with D3D12 tests even when I did nothing to D3D12 codepath? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following workitem from SpecializationConstants.md has been implemented:
Name -> SpecId matching policy
SpecializationConstant::Nameto reflected specialization constant names from SPIR-V.ShaderStages).Populate Vulkan structs during PSO creation
std::vector<VkSpecializationMapEntry>std::vector<Uint8>)VkSpecializationInfoStageCI.pSpecializationInfofor eachVkPipelineShaderStageCreateInfo.vkCreate*Pipelinescall returns.Graphics/GraphicsEngineVulkan/src/PipelineStateVkImpl.cppPipeline coverage
Tests for stage 2