perf(context): use createResponseInstance for new Response#4733
Merged
perf(context): use createResponseInstance for new Response#4733
createResponseInstance for new Response#4733Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #4733 +/- ##
=======================================
Coverage 91.48% 91.48%
=======================================
Files 177 177
Lines 11552 11556 +4
Branches 3358 3357 -1
=======================================
+ Hits 10568 10572 +4
Misses 983 983
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bundle size check
Compiler Diagnostics (tsc)
Compiler Diagnostics (typescript-go)
Reported by octocov |
HTTP Performance Benchmark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
createResponseInstance()shortcut function fornew Response()incontext.ts. As a result, the bundle size will decrease35B. It's super slight, but Hono should be as small as possible.However,
createResponseInstance()is used in onlycontext.ts. To keep maintainability, don't use it anywhere.The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code