WIP rewrite of `_check_model_sources`, improve robustness by asumagic · Pull Request #2556 · speechbrain/speechbrain

asumagic · 2024-05-30T11:29:12Z

What does this PR do?

WIP.

Change list:

Rewrite _check_model_sources to be cleaner
Add .safetensors to model extension list
- example: facebook/w2v-bert-2.0
Allow specifying the model path explicitly when the file extension is otherwise not known (or if there are multiple files)
Fix issues around the snapshots directory always getting the first directory which is problematic if there were revisions
- (although generally speaking we just return the path directly, so is this even a problem in practice?)

Before submitting

Did you read the contributor guideline?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Does your code adhere to project-specific code style and conventions?

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified
Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
Review the self-review checklist to ensure the code is ready for review

WIP rewrite of _check_model_sources, add .safetensors to heuristic

0d303eb

mravanelli requested a review from Adel-Moumen June 17, 2024 16:24

mravanelli assigned asumagic Jun 17, 2024

mravanelli added the enhancement New feature or request label Jun 17, 2024