Initialize run time cache in PDO methods#9818
Closed
rioderelfte wants to merge 6 commits intophp:PHP-8.2from
Closed
Initialize run time cache in PDO methods#9818rioderelfte wants to merge 6 commits intophp:PHP-8.2from
rioderelfte wants to merge 6 commits intophp:PHP-8.2from
Conversation
* PHP-8.1: Update new test to use EXTENSIONS section instead of SKIPIF
Contributor
|
@bwoebi ping, this failed for the Tideways suite in zend_observer. |
The intersection type needs to be marked as being allocated on the arena otherwise zend_persist_type() tries to free it and corrupts the Zend MM Heap Also we only need to allocate the space for a list of size 1 and not the whole length of the intersection type
Without the memset the memory was uninitialized and the new test segfaulted when accessing the memory in _zend_observe_fcall_begin().
Contributor
Author
|
Somehow GitHub got confused. I rebased my commit on top of the current |
bwoebi
pushed a commit
that referenced
this pull request
Oct 26, 2022
Without the memset the memory was uninitialized and the new test segfaulted when accessing the memory in _zend_observe_fcall_begin().
Member
|
Merged via 56c121c. Thanks for spotting and fixing :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the memset the memory was uninitialized and the new test segfaulted when accessing the memory in
_zend_observe_fcall_begin().