Fix GH-18438: Handling of empty data and errors in ZipArchive::addPattern#18438
Closed
ndossche wants to merge 1 commit intophp:PHP-8.3from
Closed
Fix GH-18438: Handling of empty data and errors in ZipArchive::addPattern#18438ndossche wants to merge 1 commit intophp:PHP-8.3from
ndossche wants to merge 1 commit intophp:PHP-8.3from
Conversation
…Pattern There is a ZPP arginfo violation because the empty return or error return is not always properly handled. And there is also a memory leak if creating the regular expression instance fails.
devnexen
approved these changes
Apr 26, 2025
ndossche
added a commit
that referenced
this pull request
Apr 27, 2025
* PHP-8.3: datefmt_parse/datefmt_localtime references type system fixes Fix GH-18438: Handling of empty data and errors in ZipArchive::addPattern
ndossche
added a commit
that referenced
this pull request
Apr 27, 2025
* PHP-8.4: Fix IntlDateFormatter::parseToCalendar() reference type system breaks datefmt_parse/datefmt_localtime references type system fixes Fix GH-18438: Handling of empty data and errors in ZipArchive::addPattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a ZPP arginfo violation because the empty return or error return is not always properly handled.
And there is also a memory leak if creating the regular expression instance fails.
Found with help of an experimental SA I'm developing.