Stores: Separate cross region and cross account data by partition#13791
Draft
Stores: Separate cross region and cross account data by partition#13791
Conversation
Contributor
Very good point! We can actually add this for S3, do you want me to push a change to this PR? edit: actually would be a follow-up PR in Pro |
Contributor
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 37m 2s ⏱️ Results for commit 072e84d. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Warning
Merging this PR will likely break persistence across most services utilizing cross account or cross region attributes.
AWS partitions are completely separate - this means all attributes in our stores shared across regions or even accounts still need to be separated by partition.
This PR handles this separation on the store level - by partitioning the account/region global data by AWS partition.
There might be some further issues, for example S3 does not separate the on-disk data by partition. While the stores would be separate, objects with identical names can overwrite each other. cc @bentsku
Changes
Tests
Related